From 05fabd7650f26dd55cbd3ce554799693c981cb93 Mon Sep 17 00:00:00 2001 From: Leonid Nikitin Date: Thu, 18 Apr 2024 21:46:22 +0500 Subject: [PATCH] Refactoring. Removed unnecessary methods. --- .../Controllers/Site/ProjectsController.php | 18 ------------------ .../app/Services/Site/ProjectService.php | 10 ---------- 2 files changed, 28 deletions(-) diff --git a/app/application/app/Http/Controllers/Site/ProjectsController.php b/app/application/app/Http/Controllers/Site/ProjectsController.php index 3c61c3d..8febecd 100644 --- a/app/application/app/Http/Controllers/Site/ProjectsController.php +++ b/app/application/app/Http/Controllers/Site/ProjectsController.php @@ -41,22 +41,4 @@ public function index(Request $request, ?string $language = null): View return \view('site.projects.about', $result->getData()); } - - public function about(string $project, Request $request, ?string $language = null) - { - $result = $this->projectService->getAbout($project, $language, $request->user()); - if ($result->isError()) { - $this->errors($result); - } - if ($result->isTranslation()) { - return $this->viewPageWithoutTranslation($result); - } - - if ($result->getProject()->http_href !== null) { - $link = ProjectSection::Home->url($result->getProject(), $result->getLanguage()); - return \redirect($result->getProject()->http_href . $link, 302); - } - - return \view('site.projects.about', $result->getData()); - } } diff --git a/app/application/app/Services/Site/ProjectService.php b/app/application/app/Services/Site/ProjectService.php index 8573a23..8cfb9c1 100644 --- a/app/application/app/Services/Site/ProjectService.php +++ b/app/application/app/Services/Site/ProjectService.php @@ -39,16 +39,6 @@ public function getProjects(?User $user, array $with): ServiceResultError | Serv ]); } - public function getAbout(string $projectCode, ?string $languageCode, ?User $user = null): ServiceResultError | PagePossibleWithoutTranslation - { - $project = $this->projectRepository->getProjectByCode($projectCode); - if (\is_null($project)) { - return $this->errNotFound('Project not found'); - } - - return $this->getAboutByProject($project, $languageCode, $user); - } - public function getAboutByProject(Project $project, ?string $languageCode, ?User $user = null): ServiceResultError | PagePossibleWithoutTranslation { if (