kor-elf/service-captcha
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 5 Wiki Activity

Fixed a bug where two identical symbols appeared in a captcha.

Browse Source 
The commit fixes an issue where wrong variable was passed as second argument to randomSymbols method. Previously it was using an uninitialized variable 'fakes' which was supposed to be populated by 'success' variable. The 'success' variable already has the set of valid symbols which should be used to generate fake symbols for captcha.
This commit is contained in:
Leonid Nikitin 2023-11-26 15:25:36 +06:00
parent 520a3ba068
commit 10425db5e0
Signed by: kor-elf
GPG Key ID: 604A019EB118CAC4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Captcha/Types/StringType.php
View File

@ -19,7 +19,7 @@ final class StringType extends Type
$success = $this->randomSymbols($lengthSymbols); $success = $this->randomSymbols($lengthSymbols);
$fakes = []; $fakes = [];
if (!empty($lengthFakeSymbols)) { if (!empty($lengthFakeSymbols)) {
$fakes = $this->randomSymbols($lengthFakeSymbols, $fakes); $fakes = $this->randomSymbols($lengthFakeSymbols, $success);
} }
return new Symbols( return new Symbols(